Treat BigInt type references in JSDoc as intended bigints#60863
Merged
sandersn merged 1 commit intomicrosoft:mainfrom Jan 22, 2025
Merged
Treat BigInt type references in JSDoc as intended bigints#60863sandersn merged 1 commit intomicrosoft:mainfrom
BigInt type references in JSDoc as intended bigints#60863sandersn merged 1 commit intomicrosoft:mainfrom
Conversation
jakebailey
approved these changes
Jan 18, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
LGTM but @sandersn, the guardian of JSDoc 😄
sandersn
approved these changes
Jan 22, 2025
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
This is good for consistency although (1) I did a fairly recent survey that showed that usage of these synonyms is quite low in less-than-2-year-old code (2) I would hope people using the bigint type would less likely than average to confuse the wrapper type with the primitive type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #57953