fix(60887): Incorrect Formatting on if (a) try {} finally {}

[a-tarasyuk]

Fixes #60887

[jakebailey]

I'm suspicious about this just because all of the other code in this switch case are only checking syntax kind or position info, not node equality.

[a-tarasyuk]

@jakebailey thanks for the feedback. I found that in this case, the finallyBlock should not be handled as a child of the try block to ensure the correct delta calculation

TypeScript/src/services/formatting/formatting.ts

Line 624 in 5170645

const delta = SmartIndenter.shouldIndentChildNode(options, node) ? options.indentSize! : 0;

There are other places where we handle the finallyBlock in a similar way

TypeScript/src/services/outliningElementsCollector.ts

Lines 259 to 261 in 5170645

	else if (tryStatement.finallyBlock === n) {
	const node = findChildOfKind(tryStatement, SyntaxKind.FinallyKeyword, sourceFile);
	if (node) return spanForNode(node);

I hope that makes sense., if you have any thoughts or suggestions, I’d be grateful to hear them. thanks

[jakebailey]

How does this bug not affect the try block or the catch block, then? Maybe I'm missing something...

[a-tarasyuk]

I've modified changes to rely exclusively on checking the syntax kind

[jakebailey]

@typescript-bot pack this

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
pack this	✅ Started	✅ Results

[typescript-bot]

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164566/artifacts?artifactName=tgz&fileId=B9186007CBA01B4F34C25858EFDA94F805D5C7AC878A1E404ABE28F5E4F85F1902&fileName=/typescript-5.8.0-insiders.20250118.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-60898-2".;

[jakebailey]

@typescript-bot pack this

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
pack this	✅ Started	✅ Results

[typescript-bot]

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164856/artifacts?artifactName=tgz&fileId=064C6DAC8161A217161351EE9E2DAD4C68B41E3B1FBFC831AF72E3A943D5378302&fileName=/typescript-5.9.0-insiders.20250222.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.9.0-pr-60898-5".;