Fix mistakenly disallowed default export under erasableSyntaxOnly#61210
Merged
jakebailey merged 3 commits intomicrosoft:mainfrom Feb 18, 2025
Merged
Fix mistakenly disallowed default export under erasableSyntaxOnly#61210jakebailey merged 3 commits intomicrosoft:mainfrom
jakebailey merged 3 commits intomicrosoft:mainfrom
Conversation
jakebailey
requested review from
DanielRosenwasser,
RyanCavanaugh and
andrewbranch
jakebailey
commented
Feb 18, 2025
tests/baselines/reference/erasableSyntaxOnlyDeclaration.errors.txt
Outdated
Show resolved
Hide resolved
sandersn
approved these changes
Feb 18, 2025
Member
Author
|
@typescript-bot cherry-pick this to release-5.8 |
Collaborator
typescript-bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
Collaborator
|
Hey, @jakebailey! I've created #61237 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Feb 26, 2025
…e-5.8 (#61237) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot that
export defaultandexport =are the same node, just with an extra marker. Oops.See #61175 (comment).