.NET Samples - Configuration Naming Update#4149
.NET Samples - Configuration Naming Update#4149Copilot wants to merge 21 commits intocrickman/dotnet-sample-improvementsfrom
Conversation
Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
…e-configuration-settings
…e-configuration-settings
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| OPENAI_CHAT_MODEL_NAME: ${{ vars.OPENAI_CHAT_MODEL_NAME }} | ||
| OPENAI_REASONING_MODEL_NAME: ${{ vars.OPENAI_REASONING_MODEL_NAME }} |
There was a problem hiding this comment.
@crickman I think not using "__" double underscores breaks the UserSecrets approach please ensure we can safely use single _
There was a problem hiding this comment.
User-secrets are still functional, the keys have just changed. Instead of a binding to a configuration class, the configuration keys are simply read directly. While I'm fond of class-binding for configuration, these provides alignnment between sample usage and integration tests.
Here an example of integration test secrets for local usage:
{
"AZURE_AI_PROJECT_ENDPOINT": "https://<foundry>.services.ai.azure.com/api/projects/<project>",
"AZURE_AI_MODEL_DEPLOYMENT_NAME": "gpt-4.1",
"AZURE_AI_REASONING_DEPLOYMENT_NAME": "o3",
"AZURE_AI_EMBEDDING_DEPLOYMENT_NAME": "text-embedding-3-large",
"AZURE_AI_BING_CONNECTION_ID": "skbinggrounding"
}Here is the simplified shared configuration keys: https://github.com/microsoft/agent-framework/blob/copilot/rename-configuration-settings/dotnet/src/Shared/IntegrationTests/TestSettings.cs
I've verified this works from the command line with no environmental vars defined.
Motivation and Context
Rename configuration settings for consistency within .NET and also between .NET and Python.
Validation
Most recent integration test runs:
.NET - https://github.com/microsoft/agent-framework/actions/runs/22326836567
Python - https://github.com/microsoft/agent-framework/actions/runs/22363194830
Description
Applied the following updates to configuration names: