-
Notifications
You must be signed in to change notification settings - Fork 82
Fix float formatting to match ODBC sqlcmd with hybrid approach (decimal notation with scientific fallback) #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
19
commits into
main
Choose a base branch
from
copilot/fix-float-formatting-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+878
−659
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
de9d0c2
Initial plan
Copilot 8ef7a8f
Add float64/float32 formatting to match ODBC sqlcmd behavior
Copilot 5a4abc5
Remove binary from repo and update .gitignore
Copilot bb5d504
Fix trailing whitespace in test file
Copilot b1a3ced
Add hybrid float formatting: use 'f' format with fallback to 'g' for …
Copilot 9a407bb
Enhance extreme values test to verify both e+ and e- notation
Copilot 99f5b8d
Fix extreme values test and add REAL formatting test
Copilot ef8579c
Improve REAL formatting test assertions
Copilot c53be10
Fix test configuration issues
Copilot a3b7a26
Clean up code formatting in tests
Copilot 6a8b162
Fix errcheck linting errors in test functions
Copilot 635cb07
Fix float formatting to use DatabaseTypeName for bitSize and add conn…
Copilot 38ac3ee
Improve float formatting to also handle SMALLMONEY as 32-bit
Copilot 5a574a5
Fix fallback logic for displayWidth=0 and remove trailing whitespace
Copilot 5194b35
Centralize float type default width constants
Copilot 85c8c8b
Fix golangci-lint errcheck violations in commands.go
Copilot 9f87576
Fix file handle cleanup and add displayWidth=0 test
Copilot 9611e7b
Remove commented-out dead code in connectCommand
Copilot db681ab
Merge branch 'main' into copilot/fix-float-formatting-issue
dlevy-msft-sql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,4 +51,4 @@ func TestStdinRedirectionDetection(t *testing.T) { | |
|
|
||
| // Clean up | ||
| console.Close() | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.