Skip to content

Use typing_extensions.Self #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
debonte merged 1 commit into from
Mar 26, 2025
Merged

Use typing_extensions.Self #358

debonte merged 1 commit into from
Mar 26, 2025

Conversation

@Avasam
Copy link
Contributor

@Avasam Avasam commented Mar 26, 2025 •
edited
Loading

Here's the steps I took:

  1. Re-enable PYI019 and run ruff check --fix
  2. Run ruff check --fix --unsafe-fixes and manually validate
  3. Search & replace to remove all .+?Self = TypeVar.+?\n
  4. Remove unused TypeVar imports

@Avasam Avasam force-pushed the Use-typing_extensions.Self branch from d29163d to 64b8614 Compare March 26, 2025 00:37
@debonte debonte merged commit 1fb1225 into microsoft:main Mar 26, 2025
3 checks passed
@debonte
Copy link
Contributor

debonte commented Mar 26, 2025

Thanks @Avasam!

@Avasam Avasam deleted the Use-typing_extensions.Self branch March 26, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@debonte debonte debonte approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasam @debonte