fix(codegen): fix react-native modules/components duplication #2817
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-codegen
branch
2 times, most recently
from
bc2a342 to
3c7a020
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-codegen
branch
from
3c7a020 to
d0f2866
Compare
Member
|
@Saadnajmi Do we need to generate code for iOS? Can we just change line 205 to react-native-macos/packages/react-native/package.json Lines 203 to 207 in c597bf8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In
react-native-macos0.81, runningpod installwill error out due to react-native modules/components duplication when using react-native and react-native-macos in the same repository.Test Plan:
Pod install should succeed and the app should build normally.