Skip to content

[lockfile-explorer] Change error to warning for outdated pnpm-lock.yaml format #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EasonLin0716 wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −2
Open

[lockfile-explorer] Change error to warning for outdated pnpm-lock.yaml format #5645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b195bd
Change error to warn for pnpm-lock format
EasonLin0716 Feb 19, 2026
3f678f9
doc: add changelog
EasonLin0716 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/lockfile-explorer/src/graph/lfxGraphLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import * as lockfilePath from './lockfilePath';
type PnpmLockfileVersion = 54 | 60 | 90;
type PeerDependenciesMeta = lockfileTypes.LockfilePackageInfo['peerDependenciesMeta'];

let hasWarnedAboutOutdatedFormat: boolean = false;

function createPackageLockfileDependency(options: {
name: string;
versionPath: string;
Expand Down Expand Up @@ -329,9 +331,16 @@ function createPackageLockfileEntry(options: {
slashlessRawEntryId = rawEntryId;
} else {
if (!rawEntryId.startsWith('/')) {
throw new Error('Expecting leading "/" in path: ' + JSON.stringify(rawEntryId));
if (!hasWarnedAboutOutdatedFormat) {
console.warn(
'Your pnpm-lock.yaml contains outdated version formats. Please run "rush update --full" to fix this issue.'
Copy link
Member

@iclanton iclanton Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this only happen in a case when rush update --full will fix it?

Copy link
Author

@EasonLin0716 EasonLin0716 Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog is added. Please take a look, thank you.

Does this only happen in a case when rush update --full will fix it?

This case happens when users haven't run rush update --full after migrating their pnpm version, especially from v8 to v9. Users can either run rush update --full or remove the pnpm-lock.yaml and run rush install again to fix it.

);
hasWarnedAboutOutdatedFormat = true;
}
slashlessRawEntryId = rawEntryId;
} else {
slashlessRawEntryId = rawEntryId.substring(1);
}
slashlessRawEntryId = rawEntryId.substring(1);
}

let dotPnpmSubfolder: string;
Expand Down
10 changes: 10 additions & 0 deletions common/changes/@rushstack/lockfile-explorer/fix-lockfile-version-diffs_2026-02-20-02-06.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/lockfile-explorer",
"comment": "Add user-friendly warning for outdated pnpm-lock.yaml instead of throwing an error. The warning suggests running \"rush update --full\" to fix the issue.",
"type": "patch"
}
],
"packageName": "@rushstack/lockfile-explorer"
}