http-client-java, bug fix on mock value for BinaryData #9527
+438
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
commit: |
| url: url; | ||
| nullableFloatDict: Record<float64 | null>; | ||
| encoded: Encoded; | ||
| encoding: Encoded; |
Contributor
Author
There was a problem hiding this comment.
rename due to model with property name containing "code" will be skipped for mock test (as "code=value" likely trigger a report, like "key" or "credential" etc.)
Contributor
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
weidongxu-microsoft
requested review from
XiaofeiCao,
anuchandy,
haolingdong-msft and
srnagar
as code owners
| import com.azure.core.util.BinaryData; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import org.junit.jupiter.api.Assertions; |
Member
There was a problem hiding this comment.
May I understand why the these test files are deleted?
In Generate.ps1, I saw below codes are deleted, so from my understanding, tests will be generated? But I saw three tests deleted? This might be a bit confuse to me.
# for mgmt, do not generate tests due to random mock values
$tspOptions += " --option ""@typespec/http-client-java.generate-tests=false"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9508