-
Notifications
You must be signed in to change notification settings - Fork 334
Fix optional Content-Type header detection by unifying parameter processing #9528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Type Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix optional contentType issue in the SDK
Fix optional Content-Type header detection in fromHeaderParameter
Jan 30, 2026
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Copilot
AI
changed the title
Fix optional Content-Type header detection in fromHeaderParameter
Fix optional Content-Type header detection by unifying parameter processing
Jan 30, 2026
Member
|
@copilot please fix the CI issues. |
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Contributor
Author
JoshLove-msft
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type-converter.ts, but it relies onsdkPropertybeing passed tofromSdkType. ThefromHeaderParameterfunction inoperation-converter.tsdoesn't pass the header parameter tofromSdkType, so the fix doesn't work.fromHeaderParameterto pass the header parameterptofromSdkTypeso the Content-Type detection can workfromSdkType:fromQueryParameterfromPathParameterfromHeaderParameterfromBodyParameterupdateMethodParametersdkPropertyrequired - not feasible as many callers have no property context (model base types, array/dict value types, etc.)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.