Skip to content

fix(PR184): reduce typeChecker noise when passing a float to score() #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elucchesileon merged 1 commit into from
Dec 8, 2025
Merged

fix(PR184): reduce typeChecker noise when passing a float to score() #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions mitreattack/navlayers/core/technique.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from mitreattack.navlayers.core.exceptions import (
UNSETVALUE,
BadInput,
BadType,
MissingParameters,
UnknownTechniqueProperty,
handler,
Expand Down Expand Up @@ -94,12 +93,10 @@ def score(self):
@score.setter
def score(self, score):
"""Setter for score."""
try:
typeChecker(type(self).__name__, score, int, "score")
self.__score = score
except BadType:
typeChecker(type(self).__name__, score, float, "score")
self.__score = int(score)
if isinstance(score, float):
score = int(score)
typeChecker(type(self).__name__, score, int, "score")
self.__score = score

@property
def color(self):
Expand Down