Skip to content

Conversation

@subhamg
Copy link

@subhamg subhamg commented Oct 29, 2024

No description provided.

@subhamg subhamg changed the title Update package.json chore: update package.json Oct 29, 2024
@coolsoftwaretyler
Copy link
Collaborator

Hey @subhamg - thanks for your PR!

We are working on a milestone for getting the repository ready for more contribution so we'll probably hold off on this until we finish up #129. If you want to help out, there are some details in that PR about the status of the change.

},
"peerDependencies": {
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0",
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^6.13.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^6.13.0",
"mobx": "^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0",

I think ^6.0.0 should work to do what ^6.13.0 is doing here. Was there a specific reason you had wanted to include that?

@moharamfatema
Copy link
Contributor

Any updates on this?

@andykog
Copy link
Member

andykog commented Dec 6, 2024

Closed in favour of #156

@andykog andykog closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants