Skip to content

Fix XunitLoggerProvider crash when background work logs after test disposal #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 3 commits into from
Jan 30, 2026
+14 −1
Merged

Fix XunitLoggerProvider crash when background work logs after test disposal #1229

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8e5afd
Initial plan
Copilot Jan 30, 2026
7564073
Fix test failure from background logging after xUnit test disposal
Copilot Jan 30, 2026
1b75ec0
Catch specific exception types in XunitLoggerProvider
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/Common/Utils/XunitLoggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,20 @@ public void Log<TState>(
sb.Append(exception.ToString());
}

output.WriteLine(sb.ToString());
try
{
output.WriteLine(sb.ToString());
}
catch (InvalidOperationException)
{
// Ignore exceptions from xUnit's TestOutputHelper when the test has already completed.
// Background work may continue logging after xUnit has disposed the test context.
}
catch (NullReferenceException)
{
// xUnit v3 may throw NullReferenceException in TestOutputHelper.QueueTestOutput()
// when the internal queue has been torn down after test completion.
}
}

public bool IsEnabled(LogLevel logLevel) => true;
Expand Down