Seal public Protocol reference types to prevent external inheritance #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonRpcMessageContext- seal the class (has implicit public constructor)RequestSchema(nested inElicitRequestParams) - seal the class (has implicit public constructor)LegacyTitledEnumSchema(nested inElicitRequestParams) - seal the classEnumSchematype and update all references to useLegacyTitledEnumSchemainsteadConverterclass inPrimitiveSchemaDefinition- seal the classConverterclass inResourceContents- seal the classConverterclass inContentBlock- seal the classSummary
This PR ensures that all public reference types in the Protocol namespace are either
sealedor have only internal/private/private protected constructors, preventing external inheritance.The abstract base classes (
JsonRpcMessage,JsonRpcMessageWithId,RequestParams,PaginatedRequestParams,Result,PaginatedResult,NotificationParams,ContentBlock,ResourceContents,Reference,PrimitiveSchemaDefinition,TransportBase) already hadprivate protectedconstructors.The following public classes were sealed:
JsonRpcMessageContextElicitRequestParams.RequestSchemaElicitRequestParams.LegacyTitledEnumSchemaContentBlock.ConverterResourceContents.ConverterElicitRequestParams.PrimitiveSchemaDefinition.ConverterNote: The
EnumSchematype was deleted and all references updated to useLegacyTitledEnumSchemainstead.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.