Add missing TasksCallCapability to enable proper MCP task support #1854
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enable_tasks() method was creating TasksToolsCapability without the required nested call capability. This caused VS Code Copilot and other MCP clients to fail their capability detection check (tasks?.requests?.tools?.call !== undefined), silently falling back to synchronous tool calls instead of using the proper asynchronous MCP Tasks protocol. This fix: - Imports TasksCallCapability from mcp.types - Passes call=TasksCallCapability() when creating TasksToolsCapability - Adds unit test to verify the nested capability is properly set Without this fix, long-running tools would timeout after 5 minutes instead of receiving proper asynchronous task handling. Github-Issue: #1853
maxisbey
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enable_tasks() method was creating TasksToolsCapability without
the required nested call capability. This caused VS Code Copilot and
other MCP clients to fail their capability detection check
(tasks?.requests?.tools?.call !== undefined), silently falling back
to synchronous tool calls instead of using the proper asynchronous
MCP Tasks protocol.
This fix:
Without this fix, long-running tools would timeout after 5 minutes
instead of receiving proper asynchronous task handling.
Github-Issue: #1853