refactor: add jsonrpc field to base Notification class #1895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
jsonrpc: Literal["2.0"] = "2.0"field to the baseNotificationclass, aligning with the TypeScript SDK where notification types extendJSONRPCNotification.Motivation and Context
Issue #1729 identified that notification types like
ProgressNotificationinherit fromNotification, notJSONRPCNotification, meaning they lack thejsonrpc: "2.0"field.This PR addresses the Notifications part of that issue. The Results part is intentionally not changed because:
idfield that comes from the requestResult, notJSONRPCResultResponse)Partially fixes #1729
How Has This Been Tested?
Breaking Changes
None. The
jsonrpcfield has a default value, so existing code continues to work.Types of changes
Checklist