fix(filesystem): add symlink startup test and clarify catch block comment#3361
Open
olaservo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): add symlink startup test and clarify catch block comment#3361olaservo wants to merge 1 commit intomodelcontextprotocol:mainfrom
olaservo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…ment Follow-up to modelcontextprotocol#3254 (symlinked allowed directories fix). - Add integration test in startup-validation.test.ts that spawns the server with a symlinked directory argument, verifying the startup code correctly stores both path forms - Clarify catch block comment documenting the design tradeoff when a directory doesn't exist at startup (only unresolved form is stored) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3254 (symlinked allowed directories fix), implementing the two suggestions from the review:
startup-validation.test.tsthat spawns the server with a symlinked directory argument, verifying the startup code correctly produces both path forms. This closes the gap between the unit test inpath-validation.test.ts(which manually constructs the allowedDirectories array) and the actual startup behavior.index.tsto document the design tradeoff: when a directory doesn't exist at startup, only the unresolved form is stored, so full symlink support requires the directory to exist at startup.Test plan
🦉 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com