-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: add guidance on discussing features before opening PRs #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
commit: |
9e9fc3e to
a2e643a
Compare
a2e643a to
475ef8c
Compare
CONTRIBUTING.md
Outdated
| - New public APIs or classes | ||
| - Architectural changes or refactoring | ||
| - Changes that touch multiple modules | ||
| - Features that might require spec changes (these need a [SEP](https://github.com/modelcontextprotocol/modelcontextprotocol) first) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Features that might require spec changes (these need a [SEP](https://github.com/modelcontextprotocol/modelcontextprotocol) first) | |
| - Features that might require spec changes (these need a [SEP](https://modelcontextprotocol.io/community/sep-guidelines) first) |
|
|
Thanks @pcarleton! Updated the SEP link in 762cc95. |
Expands CONTRIBUTING.md with clear guidance on the contribution process.
Motivation and Context
We've been getting PRs for features that weren't previously discussed, leading to wasted effort on both sides. This document sets clear expectations.
Key Changes
good first issue(newcomers),help wanted(experienced contributors), andready for work(maintainers)Breaking Changes
None
Types of changes
Checklist