Skip to content

Conversation

@maxisbey
Copy link
Contributor

@maxisbey maxisbey commented Jan 21, 2026

Use the composite GitHub Action from modelcontextprotocol/conformance instead of manual npx scripts for running conformance tests.

Depends on: modelcontextprotocol/conformance#113

Changes:

  • Replace pnpm run test:conformance:* with the composite action at modelcontextprotocol/conformance@<commit>
  • Remove continue-on-error: true (replaced by expected-failures baseline mechanism)
  • Add conformance-baseline.yml for tracking known failures per SDK
  • Action builds from source at the referenced commit (no npm publish dependency)
  • Pass node-version: 24 to match SDK requirements

Related PRs:

Replace manual npx conformance invocations with the composite GitHub
Action from modelcontextprotocol/conformance. This:

- Removes continue-on-error (replaced by expected-failures baseline)
- Adds conformance-baseline.yml for tracking known failures
- Builds conformance tool from source at the referenced commit
- Passes node-version: 24 to match SDK requirements
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

⚠️ No Changeset found

Latest commit: 4216a73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 21, 2026

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1416

@modelcontextprotocol/server

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1416

@modelcontextprotocol/express

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/express@1416

@modelcontextprotocol/hono

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/hono@1416

@modelcontextprotocol/node

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/node@1416

commit: 4216a73

@maxisbey
Copy link
Contributor Author

Open question for reviewers: This PR doesn't remove scripts/run-server-conformance.sh or the related package.json scripts (test:conformance:server, test:conformance:server:all, etc.). They're no longer used by CI but are still useful for local dev (pnpm run test:conformance:server).

Worth keeping for local convenience, or should we remove them and have devs run the conformance tool directly?

@maxisbey
Copy link
Contributor Author

Open question for reviewers: This PR doesn't remove scripts/run-server-conformance.sh or the related package.json scripts (test:conformance:server, test:conformance:server:all, etc.). They're no longer used by CI but are still useful for local dev (pnpm run test:conformance:server).

Worth keeping for local convenience, or should we remove them and have devs run the conformance tool directly?

After discussing with @pcarleton , we'll leave this in for now and remove later once we add a helper subcommand to the conformance repo itself which can replace this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants