-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[RFC]: tighten public API surface with explicit named exports #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
1e730e0
`v2`: replace export * with explicit named exports to tighten public …
felixweinberger 7fb1f2c
fix: restore deprecated source code, only tighten barrel exports
felixweinberger d4dfef4
refactor: deduplicate core re-exports via publicExports.ts
felixweinberger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,49 @@ | ||
| export * from './client/auth.js'; | ||
| export * from './client/authExtensions.js'; | ||
| export * from './client/client.js'; | ||
| export * from './client/middleware.js'; | ||
| export * from './client/sse.js'; | ||
| export * from './client/stdio.js'; | ||
| export * from './client/streamableHttp.js'; | ||
| export * from './client/websocket.js'; | ||
| // client/auth.ts — public OAuth API (internals are not re-exported) | ||
| export type { AddClientAuthentication, AuthResult, OAuthClientProvider } from './client/auth.js'; | ||
| export { auth, extractWWWAuthenticateParams, UnauthorizedError } from './client/auth.js'; | ||
|
|
||
| // client/authExtensions.ts | ||
| export type { | ||
| ClientCredentialsProviderOptions, | ||
| PrivateKeyJwtProviderOptions, | ||
| StaticPrivateKeyJwtProviderOptions | ||
| } from './client/authExtensions.js'; | ||
| export { | ||
| ClientCredentialsProvider, | ||
| createPrivateKeyJwtAuth, | ||
| PrivateKeyJwtProvider, | ||
| StaticPrivateKeyJwtProvider | ||
| } from './client/authExtensions.js'; | ||
|
|
||
| // client/client.ts | ||
| export type { ClientOptions } from './client/client.js'; | ||
| export { Client } from './client/client.js'; | ||
|
|
||
| // client/middleware.ts | ||
| export type { LoggingOptions, Middleware, RequestLogger } from './client/middleware.js'; | ||
| export { applyMiddlewares, createMiddleware, withLogging, withOAuth } from './client/middleware.js'; | ||
|
|
||
| // client/sse.ts | ||
| export type { SSEClientTransportOptions } from './client/sse.js'; | ||
| export { SSEClientTransport, SseError } from './client/sse.js'; | ||
|
|
||
| // client/stdio.ts | ||
| export type { StdioServerParameters } from './client/stdio.js'; | ||
| export { DEFAULT_INHERITED_ENV_VARS, getDefaultEnvironment, StdioClientTransport } from './client/stdio.js'; | ||
|
|
||
| // client/streamableHttp.ts | ||
| export type { StartSSEOptions, StreamableHTTPClientTransportOptions, StreamableHTTPReconnectionOptions } from './client/streamableHttp.js'; | ||
| export { StreamableHTTPClientTransport, StreamableHTTPError } from './client/streamableHttp.js'; | ||
|
|
||
| // client/websocket.ts | ||
| export { WebSocketClientTransport } from './client/websocket.js'; | ||
|
|
||
| // experimental exports | ||
| export * from './experimental/index.js'; | ||
| export { ExperimentalClientTasks } from './experimental/index.js'; | ||
|
|
||
| // re-export shared types | ||
| export * from '@modelcontextprotocol/core'; | ||
| // ============================================================================ | ||
| // Re-exports from @modelcontextprotocol/core | ||
| // Only symbols that are part of the public API are listed here. | ||
| // Maintained in a single file to avoid duplication across client and server. | ||
| // ============================================================================ | ||
| export * from '@modelcontextprotocol/core/public'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit exports from client