Fix bug caused by disabled gpu #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many AMD iGPUs are paired with a dGPU, and the BIOS has the option to disable the iGPU. Doing so can fix a variety of software problems related to multi-GPU-incompatible software. When this happens, rocm-smi prints an error message to stderr since the amdgpu driver is not initalized, but returns 0. Checking that there was actually data returned fixes the crash (since amd-smi correctly returns 255) for those with this hardware configuration. Signed-off-by: Owen Hilyard <hilyard.owen@gmail.com>
keith
approved these changes
Jan 5, 2026
Contributor
|
thanks! |
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Jan 6, 2026
To pull in modular/rules_mojo#69 MODULAR_ORIG_COMMIT_REV_ID: 4b48679f15145911d973acf0df57d5cf474e62a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many AMD iGPUs are paired with a dGPU, and the BIOS has the option to disable the iGPU. Doing so can fix a variety of software problems related to multi-GPU-incompatible software. When this happens, rocm-smi prints an error message to stderr since the amdgpu driver is not initalized, but returns 0. Checking that there was actually data returned fixes the crash (since amd-smi correctly returns 255) for those with this hardware configuration.