PYTHON-1357 - Refactor Cursor and CommandCursor #2691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PYTHON-1357]
Changes in this PR
_AgnosticCursorBaseis the top-level base class that is IO-agnostic and shared between both async and sync cursor implementations._AsyncCursorBaseand_CursorBaseare async and sync-specific base classes that contain code shared between cursor implementations in either the async or sync APIs.Cursor.cursor_id -> Optional[int]andCursor.address -> Optional[tuple[str, Any]], whileCommandCursor.cursor_id -> intandCommandCursor.address -> Optional[_Address]. Do we count these type hint changes as user-facing, public API changes? Note that_Address = Tuple[str, Optional[int]]._send_messageis similar between the cursor types but has enough differences to be effectively separate implementations.Test Plan
Run against the existing test suite.
Checklist
Checklist for Author
Checklist for Reviewer