Our multi-gpu fixes #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: restore compatibility with single-GPU configs Remove extraneous code (model is reassigned to CUDA device in __init__) Restore GPU device check in the command shell
….com/murphp15/allennlp.git into feature/multi-paragraph-reading-comp
murphp15
reviewed
Jul 2, 2018
| grad_clipping = params.pop_float("grad_clipping", None) | ||
| lr_scheduler_params = params.pop("learning_rate_scheduler", None) | ||
|
|
||
| if cuda_device >= 0: |
Owner
There was a problem hiding this comment.
If the model is always none now then maybe it should be removed as a parameter from the Trainer constructor?
Author
There was a problem hiding this comment.
That wasn't in my changes though, right? Pretty sure upstream modified the trainer.py quite a bit so you may want to diff against their master first.
….com/murphp15/allennlp.git into feature/multi-paragraph-reading-comp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have sorted out the chaff from the wheat - so here's the substantial fixes we have in our repo