Skip to content

Conversation

@JuneStepp
Copy link
Contributor

pytz dependency is removed. isodate is still needed for ISO durations and missing features in Python's ISO datetime parser.

closes #1442, closes #1420

pytz dependency is removed. isodate is still needed for ISO durations
and missing features in Python's ISO datetime parser.
@JuneStepp JuneStepp mentioned this pull request Nov 4, 2024
Copy link

@Mogost Mogost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code will not work in Python 3.8
But currently pyproject.toml has

requires-python = ">=3.8"

So python should be 3.8 should be dropped here or this PR should be dependent on another PR with dropping the mentioned support.

@JuneStepp
Copy link
Contributor Author

JuneStepp commented Nov 19, 2024

This code will not work in Python 3.8 But currently pyproject.toml has

requires-python = ">=3.8"

So python should be 3.8 should be dropped here or this PR should be dependent on another PR with dropping the mentioned support.

What part doesn't work on 3.8? I'm not using zoneinfo, because it wasn't actually necessary.

@Mogost
Copy link

Mogost commented Nov 20, 2024

@JuneStepp sorry I was wrong.

@silasserner
Copy link

Are these changes ready to be merged?
Would be great to get rid of Pytz.

@JuneStepp
Copy link
Contributor Author

Are these changes ready to be merged? Would be great to get rid of Pytz.

Ya. They have been.

@silasserner
Copy link

They have not been merged yet.
This commit is still just open and not merged.
And I 've checked the code and it still uses pytz.

@JuneStepp
Copy link
Contributor Author

They have not been merged yet. This commit is still just open and not merged. And I 've checked the code and it still uses pytz.

Yes. This code has been ready to be merged a long time but has not been.

@silasserner
Copy link

They have not been merged yet. This commit is still just open and not merged. And I 've checked the code and it still uses pytz.

Yes. This code has been ready to be merged a long time but has not been.

I'm fairly new as a commenter.
Do you know how to poke the maintainer?

@JuneStepp
Copy link
Contributor Author

I'm fairly new as a commenter. Do you know how to poke the maintainer?

You would do @<their username> at the beginning of your message, but that probably wouldn't be helpful here. There are many PRs that need looking at, since this repo has had very limited maintenance for a while.

@silasserner
Copy link

I give it a shot

@mvantellingen This pull request looks ready to be merged into main.
Pytz is overdue and can easily be removed with this.

@mvantellingen mvantellingen merged commit 368861c into mvantellingen:main Jan 20, 2026
@silasserner
Copy link

@mvantellingen Thanks for merging, any chance there will be a package update on pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: use zoneinfo instead of pytz

4 participants