-
-
Notifications
You must be signed in to change notification settings - Fork 611
Use standard library for date and time when possible #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pytz dependency is removed. isodate is still needed for ISO durations and missing features in Python's ISO datetime parser.
Mogost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code will not work in Python 3.8
But currently pyproject.toml has
requires-python = ">=3.8"
So python should be 3.8 should be dropped here or this PR should be dependent on another PR with dropping the mentioned support.
What part doesn't work on 3.8? I'm not using zoneinfo, because it wasn't actually necessary. |
|
@JuneStepp sorry I was wrong. |
|
Are these changes ready to be merged? |
Ya. They have been. |
|
They have not been merged yet. |
Yes. This code has been ready to be merged a long time but has not been. |
I'm fairly new as a commenter. |
You would do |
|
I give it a shot @mvantellingen This pull request looks ready to be merged into main. |
|
@mvantellingen Thanks for merging, any chance there will be a package update on pypi? |
pytz dependency is removed. isodate is still needed for ISO durations and missing features in Python's ISO datetime parser.
closes #1442, closes #1420