Allow override of private key, docker image and docker command#10
Open
tpd1001 wants to merge 3 commits intonardeas:masterfrom
Open
Allow override of private key, docker image and docker command#10tpd1001 wants to merge 3 commits intonardeas:masterfrom
tpd1001 wants to merge 3 commits intonardeas:masterfrom
Conversation
…e script more portable. Passing a $1 param to the script loads that private key from the ~/.ssh diri instead of the default id_rsa. The image on Docker Hub is suggested in the comment for an alternative to having built your own image. If you are using a different CRI, you should be able to override the docker command with the one you are using. Also some minor word tweaks.
replace ~ with $HOME for more reliable operation
…lel, should they be required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow override of private key, docker image and docker command to make script more portable.
Passing a $1 param to the script loads that private key from the ~/.ssh dir instead of the default id_rsa. The image on Docker Hub is suggested in the comment for an alternative to having built your own image. If you are using a different CRI, you should be able to override the docker command with the one you are using. Also some minor word tweaks.