added place_id support to google geocoder#233
Open
vasilevich wants to merge 1 commit intonchaulet:mainfrom
Open
added place_id support to google geocoder#233vasilevich wants to merge 1 commit intonchaulet:mainfrom
vasilevich wants to merge 1 commit intonchaulet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google has place_id support in its geocoder
So I added it in accordance with the official google api
and left lat/lon support intact.
it will give priority to lat/lon , but if lat/lon is empty, it will check if you sent the place_id variable.
why do I need place_id?
because apis such as google places autocomplete
Do not return lat/lon rather simpley a place_id.
Thank you!