(feat): move from exit to return and Run to RunE to make things testable #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the error handling in the
cleanupandruncommands to use Cobra's recommendedRunEpattern, improving testability and reliability. Instead of directly exiting the process on errors, the commands now return errors, allowing for better error propagation and handling in tests and higher-level code. The corresponding test files have also been updated to use the newRunEhandlers and include additional test coverage for error cases.Command error handling improvements:
cleanupCmdandrunCmdfrom usingRuntoRunE, replacing direct calls toos.Exit(1)with returning errors for better error propagation and testability. (cmd/cleanup.go,cmd/run.go) [1] [2]cmd/cleanup.go,cmd/run.go) [1] [2] [3]fmtrequired for error formatting. (cmd/cleanup.go,cmd/run.go) [1] [2]nilon successful completion. (cmd/cleanup.go,cmd/run.go) [1] [2]Test updates and coverage:
RunEhandlers instead ofRun, ensuring tests work with the new error handling approach. (cmd/cleanup_test.go,cmd/run_test.go) [1] [2] [3]runcommand. (cmd/run_test.go)…testable