refactor(http-agent): improve type safety and remove @ts-expect-error #7846
Conversation
This commit refactors the `src/lib/http-agent.ts` module to improve type safety and remove all instances of `@ts-expect-error`. The following changes were made: - Introduced a custom type definition for `https-proxy-agent` to properly type the `HttpsProxyAgentWithCA` class. - Added a type guard to safely handle errors in `tryGetAgent`, removing the need for `@ts-expect-error`. - Corrected the return type of `tryGetAgent` to accurately reflect all possible return values. - Refactored the `getAgent` function to properly handle the return type of `tryGetAgent`, eliminating another `@ts-expect-error`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit refactors the
src/lib/http-agent.tsmodule to improve type safety and remove all instances of@ts-expect-errorby introducing a custom type definition forhttps-proxy-agent, adding a type guard for safer error handling, and correcting the return type oftryGetAgentto ensure consuming functions can correctly infer types.PR created automatically by Jules for task 11844978332428438137 started by @serhalp