fix(types): Correctly type execa result in shell.ts #7888
Conversation
When using `execa` with the `{ reject: false }` option, the returned promise will not be rejected on failure. Instead, the resolved result object will have a `failed` property set to `true`.
In these cases, the result object is of type `ExecaError`, which contains additional properties like `shortMessage`.
This commit replaces a `@ts-expect-error` with a type assertion to correctly inform TypeScript of the result's shape in the failure case, improving type safety.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
When using `execa` with the `{ reject: false }` option, the returned promise will not be rejected on failure. Instead, the resolved result object will have a `failed` property set to `true`.
In these cases, the result object is of type `ExecaError`, which contains additional properties like `shortMessage`.
This commit replaces a `@ts-expect-error` with a type assertion to correctly inform TypeScript of the result's shape in the failure case, improving type safety.
When using `execa` with the `{ reject: false }` option, the returned promise will not be rejected on failure. Instead, the resolved result object will have a `failed` property set to `true`.
In these cases, the result object is of type `ExecaError`, which contains additional properties like `shortMessage`.
This commit replaces a `@ts-expect-error` with a type assertion to correctly inform TypeScript of the result's shape in the failure case, improving type safety.
This commit also includes updates to `package-lock.json` to ensure a consistent dependency tree and resolve CI failures.
When using `execa` with the `{ reject: false }` option, the returned promise will not be rejected on failure. Instead, the resolved result object will have a `failed` property set to `true`.
In these cases, the result object is of type `ExecaError`, which contains additional properties like `shortMessage`.
This commit replaces a `@ts-expect-error` with a type guard using the `in` operator. This allows TypeScript to correctly infer the shape of the result object in the failure case, improving type safety in a more robust and runtime-safe way than a type assertion.
This commit addresses a type-safety issue in
src/utils/shell.ts. A@ts-expect-errorwas suppressing a type error that occurred when accessing theshortMessageproperty of a failedexecacommand result. The fix introduces a type assertion to correctly inform TypeScript that when a command fails, the result object is anExecaError, which is guaranteed to have theshortMessageproperty. This change improves the type safety and robustness of the code without altering its behavior. The commit also removes unrelated changes to thepackage-lock.jsonfile to ensure a clean and focused pull request.PR created automatically by Jules for task 9154186724161591451 started by @serhalp