Skip to content

Comments

feat: fix handling of gitlab repos#7945

Open
sarahetter wants to merge 3 commits intomainfrom
sarahetter/gitlab
Open

feat: fix handling of gitlab repos#7945
sarahetter wants to merge 3 commits intomainfrom
sarahetter/gitlab

Conversation

@sarahetter
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #3771

Also not described in the issue was that we weren't displaying the correct webhook for gitlab users to add manually since we were passing through manual instead of gitlab - now it actually shows Configure the following webhook for your repository: https://api.netlify.com/hooks/gitlab as it should (and was in the code, just wasn't being exercised).


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)
image

@sarahetter sarahetter requested a review from a team as a code owner February 13, 2026 15:01
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

📊 Benchmark results

Comparing with b80b98f

  • Dependency count: 1,073 (no change)
  • Package size: 325 MB (no change)
  • Number of ts-expect-error directives: 364 (no change)

provider: 'manual',
repo_path: repoPath,
provider: repoData.provider ?? 'manual',
repo_path: repoData.repo ?? repoPath,
Copy link
Contributor

@jaredm563 jaredm563 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[small bug] I think this is dead code- we'll be prompting users for an SSH that never gets send via network request ie repoData.repo ("owner/name")

Should we do something like so only the manual case will prompt the user

const repoPath = repoData.repo ?? (await getRepoPath({ repoData }))
repo_path: repoPath,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitLab repo URL not being parsed correctly

2 participants