Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 5, 2025

☑️ Resolves

Missing feature from the stable8.

  • Add return to dialogs/spawnDialog with 2 values:
    • vm - mounted dialog component public instance
      • Allows calling public methods
    • unmount - function to programmatically unmount the dialog

It misses typing. Will be added in the next PR.

Alternative

If we say, vm and unmount should never be needed, we can return Promise resolved with the close result.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress feature: functions composables, functions, mixins and other non-components labels Apr 5, 2025
@ShGKme ShGKme requested a review from susnux April 5, 2025 20:25
@ShGKme ShGKme self-assigned this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request feature: functions composables, functions, mixins and other non-components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants