Ensure images always have a contentDescription

[AndyScherzinger]

... or null in case it is decorative.

adding @rakekniven for approval, because we have a string-freeze for Hub 26 Winter and merging this would add some new Strings which is bad for translation completeness but good from an accessibility point of view. See below.
(I didn't find the string to be in need of a descriptive translator comment, but if so, please let me know and I add them)

This info is important for screenreaders, so hard-coded strings should not be used but values in string.xml so there is no mix of languages when read to the users using screeenreader.

• Tests written, or not not needed

[rakekniven]

Hello,

From my side, that's OK.
I have no knowledge of the release planning from the Android app.

[AndyScherzinger]

Thanks for the swift feedback @rakekniven 🙏

Plan would be to release or around the Hub release, hence around 18th February 🚀

[alperozturk96]

Thank you for the PR. contentDescription should be translated string good point unless it is just decorative.

source

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16356.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	256	256
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	479	479