Skip to content

test: added test to assert auto expire list preserves versions in various buckets #54697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 9 commits into from
Jan 14, 2026
Merged

test: added test to assert auto expire list preserves versions in various buckets #54697

provokateurin merged 9 commits into from
Jan 14, 2026

Conversation

@yemkareems
Copy link
Contributor

@yemkareems yemkareems commented Aug 28, 2025

fix: added test to assert auto expire list preserves versions in various buckets

  • Resolves: #

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems self-assigned this Aug 28, 2025
@yemkareems yemkareems requested a review from a team as a code owner August 28, 2025 10:08
@yemkareems yemkareems requested review from salmart-dev and removed request for a team August 28, 2025 10:08
@susnux susnux changed the title fix: added test to assert auto expire list preserves versions in various buckets test: added test to assert auto expire list preserves versions in various buckets Aug 28, 2025
susnux
susnux reviewed Aug 28, 2025
View reviewed changes
@yemkareems yemkareems force-pushed the fix/unit-test-for-storage-auto-expire-list branch from 44efda2 to 946cb9f Compare August 28, 2025 11:09
susnux
susnux approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper labels and milestone

@yemkareems yemkareems added the 3. to review Waiting for reviews label Aug 28, 2025
@yemkareems
fix: added test to assert auto expire list preserve's version as per …
4914b4a 
…max_versions_per_interval

Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems yemkareems force-pushed the fix/unit-test-for-storage-auto-expire-list branch from 946cb9f to 4914b4a Compare August 28, 2025 11:40
@yemkareems yemkareems added this to the Nextcloud 32 milestone Aug 28, 2025
This was referenced Aug 28, 2025
Merged
Merged
Merged
provokateurin
provokateurin requested changes Sep 9, 2025
View reviewed changes
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 10, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 18, 2025
Merged
This was referenced Sep 25, 2025
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@yemkareems
fix: since removed and copy right text changed
fbd99ce 
Signed-off-by: yemkareems <yemkareems@gmail.com>
provokateurin
provokateurin requested changes Dec 15, 2025
View reviewed changes
@yemkareems
fix: offsets corrected, test added to have exact count when time is f…
bbbbc4d 
…rozen and variable count when time is dynamic

Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems
fix: php cs fix run
674381e 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems yemkareems force-pushed the fix/unit-test-for-storage-auto-expire-list branch from 3c99dfa to c9d65e1 Compare December 24, 2025 06:03
@yemkareems
fix: added Test\TestCase namespace for failing tests
9ed9a31 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems yemkareems force-pushed the fix/unit-test-for-storage-auto-expire-list branch from c9d65e1 to 9ed9a31 Compare December 24, 2025 06:31
This was referenced Jan 7, 2026
Merged
Merged
provokateurin
provokateurin requested changes Jan 14, 2026
View reviewed changes
@yemkareems
fix: refactored testBucketKeepsLatest to add invalid data assert
5f6a777 
Signed-off-by: yemkareems <yemkareems@gmail.com>
provokateurin
provokateurin requested changes Jan 14, 2026
View reviewed changes
@yemkareems
fix: removed the message
f0b90e6 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems
fix: php lint fix
fb2716a 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@provokateurin provokateurin merged commit 7d1b1de into master Jan 14, 2026
195 checks passed
@provokateurin provokateurin deleted the fix/unit-test-for-storage-auto-expire-list branch January 14, 2026 10:00
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 14, 2026
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@artonge artonge Awaiting requested review from artonge

@leftybournes leftybournes Awaiting requested review from leftybournes

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

Assignees

@yemkareems yemkareems

Labels

3. to review Waiting for reviews feedback-requested

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@yemkareems @susnux @provokateurin @sorbaugh @skjnldsv