Skip to content

fix(sharing): Use link_defaultExpDays for default expiration in web UI#58343

Open
nfebe wants to merge 1 commit intomasterfrom
fix/link-default-exp-days
Open

fix(sharing): Use link_defaultExpDays for default expiration in web UI#58343
nfebe wants to merge 1 commit intomasterfrom
fix/link-default-exp-days

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Feb 13, 2026

The link_defaultExpDays config was only used in the backend share validation but never exposed to the frontend, making it impossible to set a default expiration date different from the maximum.

The link_defaultExpDays config was only used in the backend share
validation but never exposed to the frontend, making it impossible
to set a default expiration date different from the maximum.
@nfebe nfebe requested review from a team as code owners February 13, 2026 18:35
@nfebe nfebe requested review from ArtificialOwl, artonge, icewind1991, sorbaugh and susnux and removed request for a team February 13, 2026 18:35
@julien-nc
Copy link
Member

Thank you for this PR!

This partially works. The default date is now correct: now + link_defaultExpDays if link_defaultExpDays is set.

But the maximum date is the same as the default in the UI. So even if shareapi_expire_after_n_days is higher than link_defaultExpDays, one cannot set a higher date than the default one.

I think this can be addressed in apps/files_sharing/src/mixins/SharesMixin.js where maxExpirationDateEnforced is defined.

maxExpirationDateEnforced() {

@julien-nc
Copy link
Member

IMO this can be backported to 31, 32 and 33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments