Skip to content

[stable32] fix(propagator): Improve lock behavior of propagator#58368

Open
CarlSchwan wants to merge 2 commits intostable32from
backport/58134/stable32
Open

[stable32] fix(propagator): Improve lock behavior of propagator#58368
CarlSchwan wants to merge 2 commits intostable32from
backport/58134/stable32

Conversation

@CarlSchwan
Copy link
Member

  • Resolves: #

Summary

TODO

  • ...

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 32.0.7 milestone Feb 16, 2026
@CarlSchwan CarlSchwan self-assigned this Feb 16, 2026
@CarlSchwan CarlSchwan requested a review from a team as a code owner February 16, 2026 22:09
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Feb 16, 2026
@CarlSchwan CarlSchwan requested review from Altahrim, ArtificialOwl, leftybournes and salmart-dev and removed request for a team February 16, 2026 22:10
@github-actions github-actions bot changed the title Backport/58134/stable32 [stable32] Backport/58134/stable32 Feb 16, 2026
@CarlSchwan CarlSchwan changed the title [stable32] Backport/58134/stable32 [stable32] fix(propagator): Improve lock behavior of propagator Feb 16, 2026
@CarlSchwan CarlSchwan force-pushed the backport/58134/stable32 branch 2 times, most recently from fd2ae31 to decac2a Compare February 17, 2026 09:35
Fix possible dead locks when running the propagator caused by two
requests updating the same amount rows in transactions.

- Lock rows always in the same deterministic order by sorting the
  path_hash first

- On all database outside of sqlite, also do first a SELECT FOR UPDATE
  to lock all the rows used in batch UPDATE calls, afterward to decrease
  the risk of two requests trying to lock the same rows

Signed-off-by: Carl Schwan <carlschwan@kde.org>
(cherry picked from commit cae742d)
Signed-off-by: Carl Schwan <carlschwan@kde.org>
(cherry picked from commit 3d031b0)
@CarlSchwan CarlSchwan force-pushed the backport/58134/stable32 branch from decac2a to f2ebcd3 Compare February 17, 2026 09:39
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is very red

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments