Open
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
CarlSchwan,
ChristophWurst,
come-nc and
nickvergessen
provokateurin
added
enhancement
3. to review
provokateurin
requested review from
Altahrim and
icewind1991
and removed request for
a team
provokateurin
added
the
pending documentation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/db/typed-query-builder
branch
from
6199c74 to
3240224
Compare
provokateurin
commented
Feb 17, 2026
| @@ -57,6 +58,13 @@ interface IDBConnection { | |||
| */ | |||
| public function getQueryBuilder(); | |||
Member
Author
There was a problem hiding this comment.
While not deprecating it (due to the huge amount of entries it would generate), this method could have a note that getTypedQueryBuilder is preferred now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's not possible to infer the column types in the query builder for static analysis, this at least makes the column names available, which will already provide a lot more safety than we currently have. This way it is still necessary to cast columns, but at least psalm will be able to warn about columns that weren't selected.