Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Dec 13, 2025

No description provided.

@mejo- mejo- added regression Regression of a previous working feature 2. developing Work in progress dependencies Pull requests that update a dependency file labels Dec 13, 2025
@mejo-
Copy link
Member Author

mejo- commented Dec 13, 2025

Seems like close and save buttons etc. are missing now from viewer modal. Maybe because of the @nextcloud/vue 8.28 -> 8.35 bump.

Edit: reverted this now.

@mejo- mejo- force-pushed the fix/nextcloud_files_4 branch from f497032 to 17885f7 Compare December 13, 2025 12:26
@mejo-
Copy link
Member Author

mejo- commented Dec 13, 2025

All Cypress failures seem to have happened in PRs being merged to master before already, so probably unrelated.

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mejo- and others added 4 commits December 30, 2025 00:24
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/nextcloud_files_4 branch from 17885f7 to 4c5a03b Compare December 30, 2025 00:09
@susnux susnux marked this pull request as ready for review December 30, 2025 00:13
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cypress already failing on master - so unrelated to this

@juliusknorr juliusknorr merged commit 4c0a5ed into master Dec 30, 2025
31 of 37 checks passed
@juliusknorr juliusknorr deleted the fix/nextcloud_files_4 branch December 30, 2025 13:25
@juliusknorr
Copy link
Member

Thanks @susnux <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress dependencies Pull requests that update a dependency file regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants