Conversation
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Copilot
AI
changed the title
[WIP] migrate from eslint to oxlint with @eggjs/oxlint-config
Migrate from eslint to oxlint with @eggjs/oxlint-config
Aug 9, 2025
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the linting setup from ESLint to oxlint using the official
@eggjs/oxlint-configconfiguration.Changes Made
Dependencies:
eslintandeslint-config-eggfrom devDependenciesoxlintand@eggjs/oxlint-configas devDependenciesConfiguration:
.eslintrcand.eslintignorefiles.oxlintrc.jsonwith appropriate configuration extending@eggjs/oxlint-configeslint src test --ext tstooxlintCode Quality Improvements:
typekeyword where appropriateBenefits
Configuration Details
The oxlint configuration extends
@eggjs/oxlint-configand includes sensible rule overrides to maintain compatibility with the existing codebase:All existing tests pass and the CLI functionality remains unchanged.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.