Open
Conversation
jswhisperer
reviewed
Apr 28, 2021
jswhisperer
left a comment
jswhisperer
left a comment
There was a problem hiding this comment.
The PR should ideally only contain the package.json I think, not all the config files
Author
|
got it @gregpalaci ! Would you like me to make a separate PR for the other files? Those files are, I think, the norm on all vue projects. |
eLoyyyyy
force-pushed
the
refactor/vue-update
branch
2 times, most recently
from
e398f4e to
013059e
Compare
…g nodegui-packer on the same project so you don't need npx
eLoyyyyy
force-pushed
the
refactor/vue-update
branch
from
013059e to
6491dc8
Compare
Author
|
For the update, I retained the lock files and the |
|
Sorry for the tardy reply I'm 100% with that, can kill my PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this wonderful starter project. I had trouble setting it up as it is (Initially the
qodedependencies, but after that all of the commands needed to get started). So I want to suggest these changes for this project. Some are non-essentials and others (npm scripts) are essential for me because of the commands are:webpack.Still, thanks for the starter project.