Updating SetAccessor method to support v8 14.4 #1007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v8::AccessControlenum used inSetAccessormethod was declared deprecated in v8 14.2 and removed in v8 14.4.In order to maintain signature compatibility this PR adds new enum
enum AccessControl {DEFAULT = 0};and defines newSetAccessormethod signature for v8 >=14.2.Old signature:
New signature:
AppVeyor: https://ci.appveyor.com/project/agracio/nan/builds/53366215