Skip to content

src: explicitly include <cstdlib>#8

Merged
lemire merged 1 commit intonodejs:mainfrom
VerteDinde:include-cstdlib
Jul 16, 2025
Merged

src: explicitly include <cstdlib>#8
lemire merged 1 commit intonodejs:mainfrom
VerteDinde:include-cstdlib

Conversation

@VerteDinde
Copy link
Contributor

While upgrading Chrome from trunk, nbytes is now failing to build with the following error:

In file included from ../../deps/nbytes/src/nbytes.cpp:1:
../../deps/nbytes/include/nbytes.h:604:22: error: use of undeclared identifier 'abort'
  604 |     if (idx < start) abort();
      |                      ^~~~~
../../deps/nbytes/include/nbytes.h:609:22: error: use of undeclared identifier 'abort'
  609 |     if (idx < start) abort();

It seems as though a transitive dependency that previously imported may have been removed. This PR adds into the header includes, so any future breaks don't happen.

@lemire lemire merged commit dac045c into nodejs:main Jul 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants