Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jan 30, 2026

Required manual pull-request since remaining failed web-platform tests are now passing. cc @nodejs/url

@anonrig anonrig requested a review from lemire January 30, 2026 18:44
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 30, 2026
@anonrig anonrig force-pushed the yagiz/update-ada-v-3-4-2 branch from bb26dde to fe29dec Compare January 30, 2026 18:46
@anonrig anonrig requested a review from aduh95 January 30, 2026 18:46
@aduh95
Copy link
Contributor

aduh95 commented Jan 30, 2026

FWIW it doesn't require a manual PR, it's certainly fine to push a fixup commit to the bot PR, but a manual PR also works

@anonrig anonrig requested a review from JonasBa January 30, 2026 19:25
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (ea83d32) to head (fe29dec).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61593      +/-   ##
==========================================
- Coverage   89.79%   89.77%   -0.03%     
==========================================
  Files         673      673              
  Lines      203852   203852              
  Branches    39181    39182       +1     
==========================================
- Hits       183044   182998      -46     
- Misses      13143    13189      +46     
  Partials     7665     7665              

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 30, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2026
@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants