src: support import() and import.meta in embedder-run modules #61654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a embedder_module_hdo for identifying embedder-run modules in the dynamic import handler and import.meta initializer, and a SourceTextModuleTypes for customizing source text module compilation in the JS land via compileSourceTextModule(). Also, refactors the existing embedder module compilation code to reuse the builtin resolution logic.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
legendecas
reviewed
Feb 3, 2026
| v8::Local<v8::Context> context = isolate_->GetCurrentContext(); | ||
| // Finish the await. | ||
| context->GetMicrotaskQueue()->PerformCheckpoint(isolate_); | ||
| v8::Local<v8::Value> imported_value = result.As<v8::Promise>()->Result(); |
Member
There was a problem hiding this comment.
Suggested change
| v8::Local<v8::Value> imported_value = result.As<v8::Promise>()->Result(); | |
| EXPECT_EQ(result.As<v8::Promise>()->State(), v8::Promise::kFulfilled); | |
| v8::Local<v8::Value> imported_value = result.As<v8::Promise>()->Result(); |
| // Finish the await. | ||
| context->GetMicrotaskQueue()->PerformCheckpoint(isolate_); | ||
|
|
||
| v8::Local<v8::Value> imported_value = |
Member
There was a problem hiding this comment.
Suggested change
| v8::Local<v8::Value> imported_value = | |
| EXPECT_EQ(result.As<v8::Promise>()->State(), v8::Promise::kFulfilled); | |
| v8::Local<v8::Value> imported_value = |
| kInternal: 'internal', // TODO(joyeecheung): support internal ESM. | ||
| kEmbedder: 'embedder', // Embedder ESM, also used by SEA | ||
| kUser: 'user', // User-land ESM | ||
| kDynamic: 'dynamic', // Currently only used by the facade that proxies WASM module import/exports. |
Member
There was a problem hiding this comment.
I feel like the term dynamic in ESM could be related to the dynamic import calls. Given that this creates a module with a facade, and this is also not a synthetic module, maybe we should rename it to a facade module.
Nevertheless, this is not a blocker for this PR.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61654 +/- ##
=======================================
Coverage 89.74% 89.75%
=======================================
Files 674 674
Lines 204348 204431 +83
Branches 39271 39277 +6
=======================================
+ Hits 183396 183480 +84
+ Misses 13262 13255 -7
- Partials 7690 7696 +6
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a embedder_module_hdo for identifying embedder-run modules in the dynamic import handler and import.meta initializer, and a SourceTextModuleTypes for customizing source text module compilation in the JS land via compileSourceTextModule(). Also, refactors the existing embedder module compilation code to reuse the builtin resolution logic.