Open
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61711 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 674 674
Lines 204424 204424
Branches 39287 39287
=======================================
+ Hits 183464 183465 +1
- Misses 13258 13262 +4
+ Partials 7702 7697 -5 🚀 New features to boost your workflow:
|
Adds tests to verify AbortSignal behavior in describe blocks, including timeout aborts, nested signal propagation, and manual abort triggering. Removes the TODO comment in test-runner-misc.js.
073b8ed to
89a9914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests to
test/parallel/test-runner-misc.jsto verifyAbortSignalbehavior indescribeblocks.This addresses the TODO comment:
// TODO(benjamingr) add more tests to describe + AbortSignal.Changes
describetimeout triggering signal abort.describe.Verification
tools/test.py test/parallel/test-runner-misc.js