Skip to content

Conversation

@addaleax
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector
  • @nodejs/security-wg
  • @nodejs/single-executable
  • @nodejs/sqlite
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 12, 2026
@addaleax addaleax changed the title src: remove unnecessary c_str() conversions in diagnsotic messages src: remove unnecessary c_str() conversions in diagnostic messages Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 30.43478% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.74%. Comparing base (4a13a62) to head (0428717).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_snapshotable.cc 10.00% 18 Missing ⚠️
src/node_config_file.cc 53.84% 6 Missing ⚠️
src/blob_serializer_deserializer-inl.h 0.00% 5 Missing ⚠️
src/permission/fs_permission.cc 0.00% 2 Missing ⚠️
src/node_builtins.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61786      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.02%     
==========================================
  Files         675      675              
  Lines      204674   204660      -14     
  Branches    39330    39329       -1     
==========================================
- Hits       183716   183682      -34     
- Misses      13235    13241       +6     
- Partials     7723     7737      +14     
Files with missing lines Coverage Δ
src/compile_cache.cc 80.72% <100.00%> (-0.06%) ⬇️
src/env.cc 85.07% <100.00%> (-0.16%) ⬇️
src/inspector_profiler.cc 82.36% <ø> (-0.05%) ⬇️
src/node_errors.cc 63.86% <100.00%> (-0.05%) ⬇️
src/node_sea.cc 92.67% <100.00%> (ø)
src/node_sqlite.cc 80.90% <100.00%> (ø)
src/node_builtins.cc 75.95% <0.00%> (ø)
src/permission/fs_permission.cc 69.71% <0.00%> (+0.48%) ⬆️
src/blob_serializer_deserializer-inl.h 69.38% <0.00%> (+0.51%) ⬆️
src/node_config_file.cc 81.50% <53.84%> (-0.46%) ⬇️
... and 1 more

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants