fix: use fetchWithRetry for nodevu fetch calls#8609
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8609 +/- ##
==========================================
- Coverage 75.03% 74.95% -0.09%
==========================================
Files 103 103
Lines 9062 9063 +1
Branches 312 312
==========================================
- Hits 6800 6793 -7
- Misses 2260 2268 +8
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR switches the @nodevu/core data fetch inside the majorNodeReleases generator to use the site’s standard fetchWithRetry wrapper, aiming to improve resilience and logging around nodevu network calls.
Changes:
- Use
fetchWithRetryinstead of the globalfetchwhen callingnodevu(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
|
Requesting fast-track on this as a fix for a continual papercut |
2 participants
Description
Uses our standard fetch wrapper for the nodevu fetch calls, to help with issues we've been seeing coming from this specifically. Will automatically retry if a fetch call fails, while also logging which fetch call is actually causing the problem.
Validation
nodevu data continues to load.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.