fix(wayland): combine GLFW backend check with XDG_SESSION_TYPE detection #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check using `glfwPlatformSupported` was insufficient as it only tests compilation support, not the active session type. This caused false positives on systems with Wayland-enabled GLFW libraries on X11 sessions. Now also verify the XDG_SESSION_TYPE environment variable to ensure an actual Wayland session is active, preventing the crash on x11. Fix: not-coded#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check using
glfwPlatformSupportedwas insufficient as it only tests compilation support, not the active session type. This caused false positives on systems with Wayland-enabled GLFW libraries on X11 sessions.Now also verify the XDG_SESSION_TYPE environment variable to ensure an actual Wayland session is active, preventing the crash on x11.
Fix: #73