fix(nx): allow copying generated Prisma client (asset) from 'node_modules' #33822
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed 'node_modules' from the ignore list for asset copying.
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 'node_modules' from the ignore list for asset copying.
Current Behavior
Updating Nx to v22 breaks my app. Some projects use generated Prisma clients which, because of how Prisma binaries work, have to be generated to
node_modulesin order to work both locally and in Docker context.With Nx v22 Prisma client is not copied when project is built using
@nx/esbuild:esbuild(or any other executor supportingassetsproperty) without any error or warning. It took mi couple of hours to pinpoint the exact line of code responsible for this.node_modulesdir is hardcoded there without any possibility to be overridden.Expected Behavior
Prisma client can be copied from
node_modulesto project output directory when building.Ignoring
node_modulesis removed or can be overridden. I'm open to any solution which will let me update Nx in my repository.Related Issue(s)
Fixes #