Skip to content

Conversation

@nullable-eth
Copy link
Owner

No description provided.

@nullable-eth nullable-eth requested a review from Copilot July 2, 2025 17:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release workflow to correctly handle cases with no previous tags (first release) and enhances the changelog with a dedicated "Breaking Changes" section.

  • Introduce branching logic for first-release vs. subsequent releases in both changes and release jobs
  • Default LAST_TAG to empty and detect absence of tags
  • Append a “### Breaking Changes” section in changelog.md
Comments suppressed due to low confidence (2)

.github/workflows/release.yml:65

  • The logic to detect and initialize a first release is duplicated in both the changes and release jobs. Consider extracting this into a reusable step or composite action to reduce duplication and simplify future maintenance.
          if [[ -z "$LAST_TAG" ]]; then

.github/workflows/release.yml:161

  • The "Breaking Changes" section is appended unconditionally. You should wrap this in a condition (e.g., only for major releases or when breaking-change commits exist) to avoid misleading empty sections in minor/patch releases.
            echo "### Breaking Changes" >> changelog.md

@nullable-eth nullable-eth merged commit 5410741 into main Jul 2, 2025
1 check passed
@nullable-eth nullable-eth deleted the hotfix/workflow-tag-fix branch July 2, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants