feat: support shutdown_callback argument in XXXAsyncServer #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kazuki Yamamoto <yamamoto.kazuki.24@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 94.00% 94.05% +0.05%
==========================================
Files 66 66
Lines 3053 3080 +27
Branches 156 156
==========================================
+ Hits 2870 2897 +27
Misses 136 136
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vigith
reviewed
Feb 4, 2026
Member
vigith
left a comment
vigith
left a comment
There was a problem hiding this comment.
self.shutdwon_callback = shutdown_callbackplease fix the typo here and at the usage sites too?
| so that all the async coroutines can be started from a single context | ||
| """ | ||
| aiorun.run(self.aexec(), use_uvloop=True) | ||
| aiorun.run(self.aexec(), use_uvloop=True, shutdown_callback=self.shutdwon_callback) |
Member
There was a problem hiding this comment.
Suggested change
| aiorun.run(self.aexec(), use_uvloop=True, shutdown_callback=self.shutdwon_callback) | |
| aiorun.run(self.aexec(), use_uvloop=True, shutdown_callback=self.shutdown_callback) |
typo
| to the aexec so that all the async coroutines can be started from a single context | ||
| """ | ||
| aiorun.run(self.aexec(), use_uvloop=True) | ||
| aiorun.run(self.aexec(), use_uvloop=True, shutdown_callback=self.shutdwon_callback) |
Member
There was a problem hiding this comment.
Suggested change
| aiorun.run(self.aexec(), use_uvloop=True, shutdown_callback=self.shutdwon_callback) | |
| aiorun.run(self.aexec(), use_uvloop=True, shutdown_callback=self.shutdown_callback) |
typo
| self.max_threads = min(max_threads, MAX_NUM_THREADS) | ||
| self.max_message_size = max_message_size | ||
| self.server_info_file = server_info_file | ||
| self.shutdwon_callback = shutdown_callback |
Member
There was a problem hiding this comment.
Suggested change
| self.shutdwon_callback = shutdown_callback | |
| self.shutdown_callback = shutdown_callback |
| self.max_threads = min(max_threads, MAX_NUM_THREADS) | ||
| self.max_message_size = max_message_size | ||
| self.server_info_file = server_info_file | ||
| self.shutdwon_callback = shutdown_callback |
Member
There was a problem hiding this comment.
Suggested change
| self.shutdwon_callback = shutdown_callback | |
| self.shutdown_callback = shutdown_callback |
Signed-off-by: Kazuki Yamamoto <yamamoto.kazuki.24@gmail.com>
vigith
approved these changes
Feb 4, 2026
Contributor
|
Can you please make the same change in the remaining files as well to make the API consistent?
Also, please update the documentation comment for this parameter (within the class or under |
- Also, update the documentation comment for this parameter Signed-off-by: Kazuki Yamamoto <yamamoto.kazuki.24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #310, I updated the following code in accordance with the proposed solution.